Repository navigation
Require cma - #88
Merged
Merged
Require cma#88
Conversation
cma is a dependency of geckopy and the extra evotune is removed. import geckopy raised ModuleNotFoundError without the extra, because review_assignment imports a module of the evotune subpackage. A CI job installs geckopy without extras and imports it.
Importing cma without matplotlib no longer warns on import geckopy, and the CI job imports geckopy with that warning as an error. cma stands in alphabetical order in the dependencies, and the changelog and the evotune guide state the current dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmais a dependency of geckopy, and the extraevotuneis removed.import geckopyimportscmathroughgeckopy.gather_kcats.reviewandgeckopy.kcat_tuning.evotune.cmais a pure-Python package with a wheel of 347 KB that requiresnumpyonly.cmawarns on import when matplotlib is absent, and the base install has no matplotlib. The import inevotune/tuning.pyignores that one message.The README, the evotune guide and the tutorial no longer name the extra. A CI job installs geckopy without extras and imports it with the matplotlib warning as an error.